ArchiveOrangemail archive

pdk-devel.lists.64studio.com


(List home) (Recent threads) (2 other 64studio.com lists)

Subscription Options

  • RSS or Atom: Read-only subscription using a browser or aggregator. This is the recommended way if you don't need to send messages to the list. You can learn more about feed syndication and clients here.
  • Conventional: All messages are delivered to your mail address, and you can reply. To subscribe, send an email to the list's subscribe (we seem to have lost it) address with "subscribe" in the subject line.
  • This list contains about 40 messages, beginning Oct 2008
  • This list doesn't seem to be active
Report the Spam
This button sends a spam report to the moderator. Please use it sparingly. For other removal requests, read this.
Are you sure? yes no

Patch for picax

Ad
Marco Túlio Gontijo e Silva — 1229374905Mon, 15 Dec 2008 21:01:45 +0000 (UTC)
attconfig.py.diff (618 B) 
Hello,

this is a small fix for picax, which wasn't checking if the base_path
was already set before using default.

Greetings.
Thadeu Lima de Souza Cascardo — 1229375720Mon, 15 Dec 2008 21:15:20 +0000 (UTC) 
On Mon, Dec 15, 2008 at 07:01:45PM -0200, Marco T?lio Gontijo e Silva wrote:
> Hello,
> 
> this is a small fix for picax, which wasn't checking if the base_path
> was already set before using default.
> 
> Greetings.
> -- 
> marcot
> http://marcot.iaaeee.org/
>In fact, this patch is needed so we can save the repository in a
different directory and set mediagen to use it, instead of $cwd/repo.

Regards,
Cascardo.> --- config.py.old	2008-12-15 18:15:34.532695079 -0200
> +++ config.py	2008-12-15 14:18:23.425765846 -0200
> @@ -475,8 +475,9 @@
>              new_repo_list.append(repo_item)
>      this_config["repository_list"] = new_repo_list
>  
> -    this_config["base_path"] = arglist[0]
> -    this_config["base_path"] = os.path.abspath(this_config["base_path"])
> +    if not this_config.has_key("base_path")
> +        this_config["base_path"] = arglist[0]
> +        this_config["base_path"] = os.path.abspath(this_config["base_path"])
>      if not this_config.has_key("dest_path"):
>          this_config["dest_path"] = this_config["base_path"]
>  

> _______________________________________________
> Pdk-devel mailing list
> Pdk-devel at 64studio.com
> http://lists.64studio.com/mailman/listinfo/pd...
Free Ekanayaka — 1229378666Mon, 15 Dec 2008 22:04:26 +0000 (UTC) 
Hi Marco,

|--==> On Mon, 15 Dec 2008 19:01:45 -0200, Marco T?lio Gontijo e Silva  said:

  MTGeS> Hello,
  MTGeS> this is a small fix for picax, which wasn't checking if the base_path
  MTGeS> was already set before using default.

Thanks, patch committed.

Ciao!

Free
Thadeu Lima de Souza Cascardo — 1229543668Wed, 17 Dec 2008 19:54:28 +0000 (UTC) 
On Mon, Dec 15, 2008 at 07:01:45PM -0200, Marco T?lio Gontijo e Silva wrote:
> Hello,
> 
> this is a small fix for picax, which wasn't checking if the base_path
> was already set before using default.
> 
> Greetings.
> -- 
> marcot
> http://marcot.iaaeee.org/
> 

> --- config.py.old	2008-12-15 18:15:34.532695079 -0200
> +++ config.py	2008-12-15 14:18:23.425765846 -0200
> @@ -475,8 +475,9 @@
>              new_repo_list.append(repo_item)
>      this_config["repository_list"] = new_repo_list
>  
> -    this_config["base_path"] = arglist[0]
> -    this_config["base_path"] = os.path.abspath(this_config["base_path"])
> +    if not this_config.has_key("base_path")
> +        this_config["base_path"] = arglist[0]
> +        this_config["base_path"] = os.path.abspath(this_config["base_path"])
>      if not this_config.has_key("dest_path"):
>          this_config["dest_path"] = this_config["base_path"]
>Please, note that this patch has a syntax error: a missing colon at the
end of the if line.
if ...
instead of
if ... :

Sorry for that.

Best regards,
Cascardo.
Free Ekanayaka — 1229547295Wed, 17 Dec 2008 20:54:55 +0000 (UTC) 
|--==> On Wed, 17 Dec 2008 17:54:28 -0200, Thadeu Lima de Souza Cascardo  said:

  TLdSC> On Mon, Dec 15, 2008 at 07:01:45PM -0200, Marco T?lio Gontijo e Silva wrote:
>>Hello,
>>
>>this is a small fix for picax, which wasn't checking if the base_path
>>was already set before using default.
>>
>>Greetings.
>>-- 
>>marcot
>>http://marcot.iaaeee.org/
>>

>>--- config.py.old	2008-12-15 18:15:34.532695079 -0200
>>+++ config.py	2008-12-15 14:18:23.425765846 -0200
>>@@ -475,8 +475,9 @@
>>new_repo_list.append(repo_item)
>>this_config["repository_list"] = new_repo_list
>>
>>-    this_config["base_path"] = arglist[0]
>>-    this_config["base_path"] = os.path.abspath(this_config["base_path"])
>>+    if not this_config.has_key("base_path")
>>+        this_config["base_path"] = arglist[0]
>>+        this_config["base_path"] = os.path.abspath(this_config["base_path"])
>>if not this_config.has_key("dest_path"):
>>this_config["dest_path"] = this_config["base_path"]
>>TLdSC> Please, note that this patch has a syntax error: a missing colon at the
  TLdSC> end of the if line.
  TLdSC> if ...
  TLdSC> instead of
  TLdSC> if ... :

  TLdSC> Sorry for that.

Yes, thanks, that's already fixed in git.

Ciao!

Free
Home | About | Privacy