ArchiveOrangemail archive

WebKit unassigned bugs


webkit-unassigned.lists.webkit.org
(List home) (Recent threads) (8 other WebKit lists)

Subscription Options

  • RSS or Atom: Read-only subscription using a browser or aggregator. This is the recommended way if you don't need to send messages to the list. You can learn more about feed syndication and clients here.
  • Conventional: All messages are delivered to your mail address, and you can reply. To subscribe, send an email to the list's subscribe address with "subscribe" in the subject line, or visit the list's homepage here.
  • Very high traffic list: 100+ messages per day
  • This list contains about 645,483 messages, beginning Oct 2007
  • 57 messages added yesterday
Report the Spam
This button sends a spam report to the moderator. Please use it sparingly. For other removal requests, read this.
Are you sure? yes no

[Bug 49099] New: Android's navigator.language hardcoded to "en"

Ad
bugzilla-daemon at webkit.org 1288994327Fri, 05 Nov 2010 21:58:47 +0000 (UTC)
https://bugs.webkit.org/show_bug.cgi?id=49099

           Summary: Android's navigator.language hardcoded to "en"
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Android
        OS/Version: Android
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jreck at google.com
                CC: steveblock at google.com


from: http://code.google.com/p/android/issues/detai...

Using navigator.language reports always "en" in androids browser where as
my system language is de-at and the browser UI-Language is german as well.

Looking at the attributes of the navigator object I see:
navigator.language: en
navigator.userAgent: Mozilla/5.0(Linux;U;Android
1.5;de-at;T-Mobile_G2_Touch Build/CPUCAKE) AppleWebKit/528.5+ ...
navigator.appVersion: 5.0 (Linux;U;Android 1.5; de-at; ...)

I know that navigator.language does not reflect the OS-Language but because
my browser interacts with me in german I would have expected
navigator.language to be "de"
bugzilla-daemon at webkit.org 1288994633Fri, 05 Nov 2010 22:03:53 +0000 (UTC)
https://bugs.webkit.org/show_bug.cgi?id=49099





--- Comment #1 from jreck at google.com  2010-11-05 15:03:53 PST ---
Created an attachment (id=73125)
 --> (https://bugs.webkit.org/attachment.cgi?id=731...)
Changes Android's WebCore::platformDefaultLanguage() to get the correct value from PlatformBridge
bugzilla-daemon at webkit.org 1288994665Fri, 05 Nov 2010 22:04:25 +0000 (UTC)
https://bugs.webkit.org/show_bug.cgi?id=49099


jreck at google.com changed:

           What    |Removed                     |Added----------------------------------------------------------------------------
  Attachment #73125|                            |review?, commit-queue?
               Flag|                            |
bugzilla-daemon at webkit.org 1289022401Sat, 06 Nov 2010 05:46:41 +0000 (UTC)
https://bugs.webkit.org/show_bug.cgi?id=49099





--- Comment #2 from Alexey Proskuryakov   2010-11-05 22:46:41 PST ---
Looks fine, assuming it's the normal design pattern for Android to call PlatformBridge from WebCore/platform/android files (which seems weird).
bugzilla-daemon at webkit.org 1289172109Sun, 07 Nov 2010 23:21:49 +0000 (UTC)
https://bugs.webkit.org/show_bug.cgi?id=49099


Steve Block  changed:

           What    |Removed                     |Added----------------------------------------------------------------------------
  Attachment #73125|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #3 from Steve Block   2010-11-07 15:21:49 PST ---
(From update of attachment 73125)
Yes, this is a standard pattern for Android. Chromium uses a similar approach too.
bugzilla-daemon at webkit.org 1289172173Sun, 07 Nov 2010 23:22:53 +0000 (UTC)
https://bugs.webkit.org/show_bug.cgi?id=49099


WebKit Commit Bot  changed:

           What    |Removed                     |Added----------------------------------------------------------------------------
                 CC|                            |commit-queue at webkit.org
bugzilla-daemon at webkit.org 1289173112Sun, 07 Nov 2010 23:38:32 +0000 (UTC)
https://bugs.webkit.org/show_bug.cgi?id=49099


WebKit Commit Bot  changed:

           What    |Removed                     |Added----------------------------------------------------------------------------
  Attachment #73125|review+, commit-queue+      |
               Flag|                            |




--- Comment #4 from WebKit Commit Bot   2010-11-07 15:38:32 PST ---
(From update of attachment 73125)
Clearing flags on attachment: 73125

Committed r71484: <http://trac.webkit.org/changeset/71484>
bugzilla-daemon at webkit.org 1289173117Sun, 07 Nov 2010 23:38:37 +0000 (UTC)
https://bugs.webkit.org/show_bug.cgi?id=49099


WebKit Commit Bot  changed:

           What    |Removed                     |Added----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from WebKit Commit Bot   2010-11-07 15:38:38 PST ---
All reviewed patches have been landed.  Closing bug.
Home | About | Privacy